gianm commented on issue #6743: IncrementalIndex generally overestimates theta 
sketch size
URL: 
https://github.com/apache/incubator-druid/issues/6743#issuecomment-512129692
 
 
   @himanshug, I think most of that idea is good, except I'd prefer a special 
return value from `aggregate` rather than throwing an exception, for two 
reasons: exceptions are expensive to generate, and also that this situation is 
not really 'exceptional' (certain aggregators might be expected to exceed min 
size somewhat often).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to