gianm commented on issue #6743: IncrementalIndex generally overestimates theta sketch size URL: https://github.com/apache/incubator-druid/issues/6743#issuecomment-512131384 Are you still interested in writing up a proposal? Would you be interested in implementing this as well? Btw, a couple things to think about- 1. Each ByteBuffer has some memory overhead, on the order of I think 30-60 bytes in the heap or something like that. So any dynamically growable aggregator that has to grow should choose its min size in order to avoid creating too many ByteBuffers. 2. Your proposed getMinimumOffheapSize is meant to be paired with getMaxIntermediateSize. It would be better if their names were more similar (getMinIntermediateSize?).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
