clintropolis commented on a change in pull request #8141: Use PartitionsSpec
for all task types
URL: https://github.com/apache/incubator-druid/pull/8141#discussion_r307048433
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
##########
@@ -1439,38 +1442,12 @@ public IndexTuningConfig withBasePersistDirectory(File
dir)
);
}
- public IndexTuningConfig withMaxTotalRows(Long maxTotalRows)
- {
- return new IndexTuningConfig(
- maxRowsPerSegment,
- maxRowsInMemory,
- maxBytesInMemory,
- maxTotalRows,
- numShards,
- partitionDimensions,
- indexSpec,
- indexSpecForIntermediatePersists,
- maxPendingPersists,
- forceGuaranteedRollup,
- reportParseExceptions,
- pushTimeout,
- basePersistDirectory,
- segmentWriteOutMediumFactory,
- logParseExceptions,
- maxParseExceptions,
- maxSavedParseExceptions
- );
- }
-
- public IndexTuningConfig withMaxRowsPerSegment(int maxRowsPerSegment)
+ public IndexTuningConfig withPartitoinsSpec(PartitionsSpec partitionsSpec)
Review comment:
typo: `withPartitoinsSpec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
