clintropolis commented on a change in pull request #8141: Use PartitionsSpec
for all task types
URL: https://github.com/apache/incubator-druid/pull/8141#discussion_r307049112
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
##########
@@ -316,7 +316,10 @@ public TaskStatus run(final TaskToolbox toolbox)
AppenderatorDriverAddResult addResult = driver.add(inputRow,
sequenceName, committerSupplier);
if (addResult.isOk()) {
- if (addResult.isPushRequired(tuningConfig)) {
+ final boolean isPushRequired =
Review comment:
Any reason not to push this down into the `AppenderatorDriverAddResult` like
it was previously? Is the other `AppenderatorDriverAddResult.isPushRequired`
method still legitimately used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
