clintropolis commented on a change in pull request #8141: Use PartitionsSpec
for all task types
URL: https://github.com/apache/incubator-druid/pull/8141#discussion_r307049486
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
##########
@@ -595,7 +595,10 @@ public void run()
if (addResult.isOk()) {
// If the number of rows in the segment exceeds the
threshold after adding a row,
// move the segment out from the active segments of
BaseAppenderatorDriver to make a new segment.
- if (addResult.isPushRequired(tuningConfig) &&
!sequenceToUse.isCheckpointed()) {
+ final boolean isPushRequired =
Review comment:
same thing re `isPushRequired`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
