leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307371431
########## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ########## @@ -67,14 +67,14 @@ // "legacy" should be non-null due to toolChest.mergeResults final boolean legacy = Preconditions.checkNotNull(query.isLegacy(), "WTF?! Expected non-null legacy"); - if (responseContext.get(ResponseContext.CTX_COUNT) != null) { - long count = (long) responseContext.get(ResponseContext.CTX_COUNT); + if (responseContext.get(ResponseContext.Key.COUNT) != null) { Review comment: I think ```java Long numScannedRows = responseContext.get(ResponseContext.Key.COUNT); if (numScannedRows != null) { ... } ``` would be clearer ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org