leventov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307378386
########## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java ########## @@ -266,7 +261,7 @@ public void cleanup(Iterator<ScanResultValue> iterFromMake) private long calculateLimit(ScanQuery query, ResponseContext responseContext) Review comment: I think it would be clearer to call this method "calculateRemainingScanRowsLimit" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
