leventov commented on a change in pull request #8157: Enum of ResponseContext
keys
URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307376371
##########
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java
##########
@@ -121,9 +121,7 @@
final Filter filter = Filters.convertToCNFFromQueryContext(query,
Filters.toFilter(query.getFilter()));
- if (responseContext.get(ResponseContext.CTX_COUNT) == null) {
- responseContext.put(ResponseContext.CTX_COUNT, 0L);
- }
+ responseContext.merge(ResponseContext.Key.COUNT, 0L);
Review comment:
The semantic of this call (establishing a value in the context, if absent)
is less evident now than before. Please add a comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
