leventov commented on a change in pull request #8157: Enum of ResponseContext
keys
URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r307358740
##########
File path:
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -358,8 +358,8 @@ private void
computeUncoveredIntervals(TimelineLookup<String, ServerSelector> ti
// Which is not necessarily an indication that the data doesn't exist
or is
// incomplete. The data could exist and just not be loaded yet. In
either
// case, though, this query will not include any data from the
identified intervals.
- responseContext.put(ResponseContext.CTX_UNCOVERED_INTERVALS,
uncoveredIntervals);
-
responseContext.put(ResponseContext.CTX_UNCOVERED_INTERVALS_OVERFLOWED,
uncoveredIntervalsOverflowed);
+ responseContext.merge(ResponseContext.Key.UNCOVERED_INTERVALS,
uncoveredIntervals);
+
responseContext.merge(ResponseContext.Key.UNCOVERED_INTERVALS_OVERFLOWED,
uncoveredIntervalsOverflowed);
Review comment:
`uncoveredIntervalsOverflowed` should be based on post-merge size of the
list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
