ccaominh commented on a change in pull request #8304: Add group_id to the
sys.tasks table
URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r316333477
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitorTest.java
##########
@@ -195,6 +195,7 @@ public TaskStatusResponse getTaskStatus(String taskId)
return new TaskStatusResponse(
taskId,
new TaskStatusPlus(
+ taskId,
Review comment:
Why is `taskId` passed in as the `groupId` argument? Would using `"groupId"`
or a `GROUP_ID` named constant work here?
If `groupId` is changed to `parentId`, then a named constant `NO_PARENT_ID =
""` would work well here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
