ccaominh commented on a change in pull request #8304: Add group_id to the
sys.tasks table
URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r316349740
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java
##########
@@ -1012,6 +1012,7 @@ public void testTasksTable() throws Exception
String json = "[{\n"
+ "\t\"id\": \"index_wikipedia_2018-09-20T22:33:44.911Z\",\n"
+ + "\t\"groupId\":
\"index_wikipedia_2018-09-20T22:33:44.911Z\",\n"
Review comment:
Does it make sense to use a value here that's different from the "id" to
confirm the implementation sets the value appropriately (i.e., the
implementation does not always have this value equal to "id")?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
