ccaominh commented on a change in pull request #8304: Add group_id to the
sys.tasks table
URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r316347913
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/AbstractParallelIndexSupervisorTaskTest.java
##########
@@ -138,6 +140,12 @@ protected void initializeIntermeidaryDataManager() throws
IOException
public String runTask(Object taskObject)
{
final Task subTask = (Task) taskObject;
+ try {
+ getTaskStorage().insert(subTask, TaskStatus.running(subTask.getId()));
Review comment:
It looks like the subtask only starts running after `subTask.run()` is
called below. What cleans up the task running status created here if:
- The task never starts running (task is not ready, so `subTask.run()` is
not called)
- The task starts running but unexpectedly fails during execution
If those scenarios need to be considered, then added tests for them will be
useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
