jon-wei commented on a change in pull request #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r323015408
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/BasicAuthDBConfig.java
##########
@@ -27,23 +27,32 @@
private final PasswordProvider initialAdminPassword;
private final PasswordProvider initialInternalClientPassword;
+ private final String initialAdminUser;
+ private final String initialAdminRole;
+ private final String initialAdminGroupMapping;
private final boolean enableCacheNotifications;
private final long cacheNotificationTimeout;
private final int iterations;
public BasicAuthDBConfig(
final PasswordProvider initialAdminPassword,
final PasswordProvider initialInternalClientPassword,
- final Boolean enableCacheNotifications,
- final Long cacheNotificationTimeout,
- final int iterations
+ final String initialAdminUser,
+ final String initialAdminRole,
+ final String initialAdminGroupMapping,
+ final boolean enableCacheNotifications,
+ final long cacheNotificationTimeout,
+ final int credentialIterations
)
{
this.initialAdminPassword = initialAdminPassword;
this.initialInternalClientPassword = initialInternalClientPassword;
+ this.initialAdminUser = initialAdminUser;
+ this.initialAdminRole = initialAdminRole;
+ this.initialAdminGroupMapping = initialAdminGroupMapping;
this.enableCacheNotifications = enableCacheNotifications;
this.cacheNotificationTimeout = cacheNotificationTimeout;
- this.iterations = iterations;
+ this.iterations = credentialIterations;
Review comment:
nit: Suggest renaming `iterations` and its getter as well here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
