jon-wei commented on a change in pull request #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r323021982
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/CommonCacheNotifier.java
##########
@@ -182,18 +213,43 @@ public void addUpdate(String updatedItemName, byte[]
updatedItemData)
return futures;
}
- private URL getListenerURL(DruidNode druidNode, String baseUrl, String
itemName)
+ private List<ListenableFuture<StatusResponseHolder>> sendUpdate(byte[]
serializedEntity)
Review comment:
This sendUpdate method should be removed as a result of deleting the unused
codepaths in this class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
