jon-wei commented on a change in pull request #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r323021833
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/CommonCacheNotifier.java
##########
@@ -106,23 +126,26 @@ public void start()
Pair<String, byte[]> update = updateQueue.take();
String authorizer = update.lhs;
byte[] serializedMap = update.rhs;
- BasicAuthDBConfig authorizerConfig =
itemConfigMap.get(update.lhs);
- if (!authorizerConfig.isEnableCacheNotifications()) {
+
+ BasicAuthDBConfig dbConfig = itemConfigMap == null ? itemConfig
: itemConfigMap.get(update.lhs);
+ if (!dbConfig.isEnableCacheNotifications()) {
continue;
}
LOG.debug(callerName + ":Sending cache update notifications");
// Best effort, if a notification fails, the remote node will
eventually poll to update its state
// We wait for responses however, to avoid flooding remote nodes
with notifications.
- List<ListenableFuture<StatusResponseHolder>> futures =
sendUpdate(
- authorizer,
- serializedMap
- );
+ List<ListenableFuture<StatusResponseHolder>> futures;
+ if (authorizer != null) {
Review comment:
The authorizer will always be non-null here, the `addUpdate` method that
would have allowed it to be null is not used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
