jihoonson commented on a change in pull request #8550: JsonParserIterator.init
future timeout
URL: https://github.com/apache/incubator-druid/pull/8550#discussion_r325433481
##########
File path: server/src/main/java/org/apache/druid/client/JsonParserIterator.java
##########
@@ -146,6 +158,16 @@ private void init()
objectCodec = jp.getCodec();
}
}
+ catch (TimeoutException ignored) {
+ throw new QueryInterruptedException(
+ new ResourceLimitExceededException(
Review comment:
I think `TimeoutException` is more appropriate than
`ResourceLimitExceededException` here. It's supposed to be used for only
physical resources such as memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]