jihoonson commented on a change in pull request #8550: JsonParserIterator.init
future timeout
URL: https://github.com/apache/incubator-druid/pull/8550#discussion_r325478210
##########
File path: server/src/main/java/org/apache/druid/client/JsonParserIterator.java
##########
@@ -52,12 +56,14 @@
private final String host;
private final ObjectMapper objectMapper;
private final BytesAccumulatingResponseHandler responseHandler;
+ private final boolean hasTimeout;
+ private final long timeoutAt;
public JsonParserIterator(
JavaType typeRef,
Future<InputStream> future,
String url,
- Query<T> query,
+ @Nullable Query<T> query,
Review comment:
Would you please add `@Nullable` to the member variable `query` as well?
Then Intellij will perform a proper inspection based on the annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
