gianm commented on a change in pull request #8644: Fix Kinesis resharding issues
URL: https://github.com/apache/incubator-druid/pull/8644#discussion_r332585125
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
##########
@@ -219,7 +234,34 @@ protected int getTaskGroupIdForPartition(String
partitionId)
partitionIds.add(partitionId);
}
- return partitionIds.indexOf(partitionId) %
spec.getIoConfig().getTaskCount();
+ Integer intForModulo = extractShardNumberFromShardId(partitionId);
+ if (intForModulo == null) {
+ intForModulo = getHashIntFromShardId(partitionId);
+ }
+
+ return Math.abs(intForModulo % spec.getIoConfig().getTaskCount());
+ }
+
+ private Integer extractShardNumberFromShardId(String shardId)
+ {
+ String numOnly = StringUtils.replace(shardId, "shardId-", "");
+ try {
+ Long shardNum = DimensionHandlerUtils.convertObjectToLong(numOnly);
Review comment:
How long can shard numbers be? (Does this need to be a long or bigint
perhaps?)
Or, it might be cleaner to treat them as bytes and toss them into a SHA
hasher, then pick 32 bits off the hash later on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
