gianm commented on a change in pull request #8644: Fix Kinesis resharding issues
URL: https://github.com/apache/incubator-druid/pull/8644#discussion_r332805097
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
##########
@@ -234,26 +232,24 @@ protected int getTaskGroupIdForPartition(String
partitionId)
partitionIds.add(partitionId);
}
- Integer intForModulo = extractShardNumberFromShardId(partitionId);
- if (intForModulo == null) {
- intForModulo = getHashIntFromShardId(partitionId);
+ BigInteger numberFromShardId = extractShardNumberFromShardId(partitionId);
Review comment:
Would be nice to include a comment here about why we bother with the
BigInteger stuff. It looks strange at first glance, and a reader might wonder
if it's required for some reason (it's not, from what you said in your other
comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
