gianm commented on a change in pull request #8644: Fix Kinesis resharding issues
URL: https://github.com/apache/incubator-druid/pull/8644#discussion_r332804841
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
##########
@@ -314,4 +356,94 @@ protected boolean
useExclusiveStartSequenceNumberForNonFirstSequence()
{
return true;
}
+
+ @Override
+ protected Map<String, OrderedSequenceNumber<String>>
filterDeadShardsFromStartingOffsets(
+ Map<String, OrderedSequenceNumber<String>> startingOffsets
+ )
+ {
+ Map<String, OrderedSequenceNumber<String>> filteredOffsets = new
HashMap<>();
+ for (Map.Entry<String, OrderedSequenceNumber<String>> entry :
startingOffsets.entrySet()) {
+ if
(!entry.getValue().get().equals(KinesisSequenceNumber.END_OF_SHARD_MARKER)) {
+ filteredOffsets.put(entry.getKey(), entry.getValue());
+ } else {
+ log.info("Excluding shard[%s] because it has reached EOS.",
entry.getKey());
+ }
+ }
+ return filteredOffsets;
+ }
+
+ @Override
+ protected void cleanupDeadShards(Set<String> expiredShards)
+ {
+ log.info("Cleaning up dead shards: " + expiredShards);
+
+ final KinesisDataSourceMetadata dataSourceMetadata =
+ (KinesisDataSourceMetadata)
getIndexerMetadataStorageCoordinator().getDataSourceMetadata(dataSource);
Review comment:
> Did you have some specific sanity checks in mind?
I was thinking stuff like: the new partition set is a subset of the old one,
and offsets haven't changed (the method is named `cleanupDeadShards` so it
shouldn't be changing offsets or adding partitions).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
