clintropolis commented on a change in pull request #8566: Upgrade Calcite to
1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r332786236
##########
File path:
extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/filter/sql/BloomDimFilterSqlTest.java
##########
@@ -150,12 +153,21 @@ public void testBloomFilterExprFilter() throws Exception
.dataSource(CalciteTests.DATASOURCE1)
.intervals(querySegmentSpec(Filtration.eternity()))
.granularity(Granularities.ALL)
- .filters(
- new ExpressionDimFilter(
-
StringUtils.format("(bloom_filter_test(concat(\"dim2\",'-foo'),'%s') == 1)",
base64),
+ .virtualColumns(
+ new ExpressionVirtualColumn(
Review comment:
This test was testing the `bloom_filter_test` expression macro function
rather than a generic bloom filter sql test, so I think the query needs to
change to continue to do that, or this test be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
