clintropolis commented on a change in pull request #8566: Upgrade Calcite to 1.21 URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r332786435
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java ########## @@ -352,10 +356,11 @@ public SqlOperatorConversion lookupOperatorConversion(final SqlOperator operator @Override public void lookupOperatorOverloads( - final SqlIdentifier opName, - final SqlFunctionCategory category, - final SqlSyntax syntax, - final List<SqlOperator> operatorList + SqlIdentifier opName, Review comment: why no `final`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
