clintropolis commented on a change in pull request #8566: Upgrade Calcite to
1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r332783701
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -3108,20 +3147,14 @@ public void testCountStarWithDegenerateFilter() throws
Exception
.intervals(querySegmentSpec(Filtration.eternity()))
.granularity(Granularities.ALL)
.filters(
- and(
- selector("dim2", "a", null),
- or(
- bound("dim1", "a", null, true, false, null,
StringComparators.LEXICOGRAPHIC),
- not(selector("dim1", null, null))
- )
- )
+ selector("dim2", "a", null)
)
.aggregators(aggregators(new CountAggregatorFactory("a0")))
.context(TIMESERIES_CONTEXT_DEFAULT)
.build()
),
ImmutableList.of(
- new Object[]{NullHandling.sqlCompatible() ? 2L : 1L}
+ new Object[]{NullHandling.sqlCompatible() ? 2L : 2L}
Review comment:
can drop ternary condition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
