clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r333392198
##########
File path: processing/src/main/java/org/apache/druid/query/QueryToolChest.java
##########
@@ -113,9 +113,10 @@ public ObjectMapper decorateObjectMapper(final
ObjectMapper objectMapper, final
* function is used in the default {@link ResultMergeQueryRunner} provided by
* {@link QueryToolChest#mergeResults(QueryRunner)} and can be used in
additional future merge implementations
*/
+ @Nullable
Review comment:
Updated javadoc with new usage in this PR, describe implications of
returning `null`, also added precondition checks for `ResultMergeQueryRunner`
comparator and mergeFn factories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
