clintropolis commented on a change in pull request #8578: parallel broker
merges on fork join pool
URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r333918526
##########
File path:
server/src/main/java/org/apache/druid/guice/DruidProcessingModule.java
##########
@@ -135,6 +136,26 @@ public ExecutorService getProcessingExecutorService(
);
}
+ @Provides
+ @ManageLifecycle
+ public LifecycleForkJoinPoolProvider
getMergeProcessingPoolProvider(DruidProcessingConfig config)
+ {
+ return new LifecycleForkJoinPoolProvider(
+ config.getNumThreadsMergePool(),
+ ForkJoinPool.defaultForkJoinWorkerThreadFactory, // todo: ?
Review comment:
Ah, no this was for whether or not I was going to set custom thread names as
@drcrallen did in #5913, see here
https://github.com/apache/incubator-druid/pull/5913/files#diff-fa77f3240f159148c9eac7faa94c516fR47.
I've decided against it for now and removed the todo since all of the logs are
debug level other than the unhandled exception handler I just added, but am
open to discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
