clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r333392318
########## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ########## @@ -0,0 +1,1059 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.java.util.common.guava; + +import com.google.common.collect.Lists; +import com.google.common.collect.Ordering; +import com.google.common.primitives.Ints; +import org.apache.druid.java.util.common.RE; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.utils.JvmUtils; + +import javax.annotation.Nullable; +import java.io.IOException; +import java.util.ArrayDeque; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; +import java.util.Objects; +import java.util.PriorityQueue; +import java.util.Queue; +import java.util.concurrent.ArrayBlockingQueue; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.ForkJoinPool; +import java.util.concurrent.RecursiveAction; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import java.util.function.BinaryOperator; + +/** + * Artisanal, locally-sourced, hand-crafted, gluten and GMO free, bespoke, small-batch parallel merge combinining sequence + */ +public class ParallelMergeCombiningSequence<T> extends YieldingSequenceBase<T> +{ + private static final Logger LOG = new Logger(ParallelMergeCombiningSequence.class); + + private final ForkJoinPool workerPool; + private final List<Sequence<T>> baseSequences; + private final Ordering<T> orderingFn; + private final BinaryOperator<T> combineFn; + private final int queueSize; + private final boolean hasTimeout; + private final long timeoutAt; + private final int queryPriority; // not currently used :( + private final int yieldAfter; + private final int batchSize; + private final int parallelism; + private final CancellationGizmo cancellationGizmo; + + public ParallelMergeCombiningSequence( + ForkJoinPool workerPool, + List<Sequence<T>> baseSequences, + Ordering<T> orderingFn, + BinaryOperator<T> combineFn, + boolean hasTimeout, + long timeoutMillis, + int queryPriority, + int parallelism, + int yieldAfter, + int batchSize + ) + { + this.workerPool = workerPool; + this.baseSequences = baseSequences; + this.orderingFn = orderingFn; + this.combineFn = combineFn; + this.hasTimeout = hasTimeout; + this.timeoutAt = System.currentTimeMillis() + timeoutMillis; Review comment: Not :100:, but went ahead and made it consistently use `System.nanoTime` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
