jihoonson commented on a change in pull request #8905: Retrying with a backward
compatible task type on unknown task type error in parallel indexing
URL: https://github.com/apache/incubator-druid/pull/8905#discussion_r348264418
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseSubTaskSpec.java
##########
@@ -66,4 +66,28 @@ public SinglePhaseSubTask newSubTask(int numAttempts)
new DummyForInjectionAppenderatorsManager()
);
}
+
+ @Override
+ public SinglePhaseSubTask newSubTaskWithBackwardCompatibleType(int
numAttempts)
+ {
+ return new SinglePhaseSubTask(
+ null,
+ getGroupId(),
+ null,
+ getSupervisorTaskId(),
+ numAttempts,
+ getIngestionSpec(),
+ getContext(),
+ null,
+ null,
+ new DummyForInjectionAppenderatorsManager()
+ )
+ {
+ @Override
+ public String getType()
+ {
+ return SinglePhaseSubTask.OLD_TYPE_NAME;
Review comment:
Returning a different `type` works, but the class should be registered on
Jackson properly. I fixed it and added a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
