jihoonson commented on a change in pull request #8905: Retrying with a backward
compatible task type on unknown task type error in parallel indexing
URL: https://github.com/apache/incubator-druid/pull/8905#discussion_r348264431
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitor.java
##########
@@ -265,6 +263,22 @@ private void retry(String subTaskSpecId, MonitorEntry
monitorEntry, TaskStatusPl
}
}
+ private T submitTask(SubTaskSpec<T> spec, int numAttempts)
+ {
+ T task = spec.newSubTask(numAttempts);
+ try {
+ indexingServiceClient.runTask(task);
Review comment:
This won't retry immediately but will exhaust retries in DruidLeaderClient.
Yes, ideally it should be able to detect the problem before it retries, but I'm
not sure whether that refactoring is worth to do because 1) it's not easy to
teach the logic of the caller to DruidLeaderClient, 2) it will happen only
during a particular type of rolling update, 3) and retries won't take much time
compared to the total indexing time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
