jihoonson commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/druid/pull/7306#discussion_r369335436
########## File path: server/src/main/java/org/apache/druid/metadata/SegmentsMetadata.java ########## @@ -33,11 +33,11 @@ import java.util.Set; /** - * The difference between this class and org.apache.druid.sql.calcite.schema.MetadataSegmentView is that this - * class resides in Coordinator's memory, while org.apache.druid.sql.calcite.schema.MetadataSegmentView resides - * in Broker's memory. + * The difference between this class and org.apache.druid.sql.calcite.schema.MetadataSegmentView is that this class + * resides in Coordinator's memory, while org.apache.druid.sql.calcite.schema.MetadataSegmentView resides in Broker's + * memory. */ -public interface MetadataSegmentManager +public interface SegmentsMetadata Review comment: I also feel like `SegmentsMetadata` isn't enough. I find it confusing since the name can be read as the metadata of a set of segments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
