jihoonson commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369322905
##########
File path: core/src/main/java/org/apache/druid/segment/SegmentUtils.java
##########
@@ -78,16 +78,14 @@ public static int getVersionFromDir(File inDir) throws
IOException
}
/**
- * Returns a String with identifiers of "segments" comma-separated. Useful
for log messages. Not useful for anything
- * else, because this doesn't take special effort to escape commas that
occur in identifiers (not common, but could
- * potentially occur in a datasource name).
+ * Returns an object whose toString() returns a String with identifiers of
the given segments, comma-separated. Useful
+ * for log messages. Not useful for anything else, because this doesn't take
special effort to escape commas that
+ * occur in identifiers (not common, but could potentially occur in a
datasource name).
*/
- public static String commaSeparateIdentifiers(final Collection<DataSegment>
segments)
+ public static Object commaSeparatedIdentifiers(final Collection<DataSegment>
segments)
Review comment:
Hmm, the method name doesn't look valid anymore. Maybe
`lazyCollectionOfSegmentIds`?
Also why not having `Collection<SegmentId>` as the return type instead of
`Object`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
