jihoonson commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369322108
##########
File path:
core/src/main/java/org/apache/druid/metadata/MetadataStorageConnector.java
##########
@@ -36,7 +37,7 @@ Void insertOrUpdate(
byte[] value
);
- byte[] lookup(
+ @Nullable byte[] lookup(
Review comment:
Would you add a javadoc saying when it can be null? Perhaps it would be
```
/**
* Returns the value of the valueColumn when there is only one row matched
to the given key.
* This method returns null if there is no such row and throws an error if
there are more than one rows.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
