jihoonson commented on a change in pull request #7306: Reconcile terminology
and method naming to 'used/unused segments'; Rename MetadataSegmentManager to
MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369901264
##########
File path:
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java
##########
@@ -141,15 +175,29 @@ SegmentIdWithShardSpec allocatePendingSegment(
);
/**
- * Delete pending segments created in the given interval for the given
dataSource from the pending segments table.
- * The {@code created_date} field of the pending segments table is checked
to find segments to be deleted.
+ * Delete pending segments created in the given interval belonging to the
given data source from the pending segments
+ * table. The {@code created_date} field of the pending segments table is
checked to find segments to be deleted.
+ *
+ * Note that the semantic of the interval (for `created_date`s) is different
from the semantic of the interva
+ * parameters in some other methods in this class, such as {@link
#retrieveUsedSegmentsForInterval} (where the
+ * interval is about the time column value in rows belonging to the segment).
*
* @param dataSource dataSource
* @param deleteInterval interval to check the {@code created_date} of
pendingSegments
*
* @return number of deleted pending segments
*/
- int deletePendingSegments(String dataSource, Interval deleteInterval);
+ int deletePendingSegmentsCreatedInInterval(String dataSource, Interval
deleteInterval);
+
+ /**
+ * Delete all pending segments belonging to the given data source from the
pending segments table.
+ * The {@code created_date} field of the pending segments table is checked
to find segments to be deleted.
Review comment:
This javadoc is for a different method: `int deletePendingSegments(String
dataSource);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
