suneet-s commented on a change in pull request #9247: Add JoinableFactory
interface and use it in the query stack.
URL: https://github.com/apache/druid/pull/9247#discussion_r370718585
##########
File path:
processing/src/main/java/org/apache/druid/query/ReferenceCountingSegmentQueryRunner.java
##########
@@ -22,39 +22,41 @@
import org.apache.druid.java.util.common.guava.Sequence;
import org.apache.druid.java.util.common.guava.Sequences;
import org.apache.druid.query.context.ResponseContext;
-import org.apache.druid.segment.ReferenceCountingSegment;
+import org.apache.druid.segment.ReferenceCounter;
+import org.apache.druid.segment.Segment;
-/**
- */
public class ReferenceCountingSegmentQueryRunner<T> implements QueryRunner<T>
{
private final QueryRunnerFactory<T, Query<T>> factory;
- private final ReferenceCountingSegment adapter;
+ private final Segment segment;
+ private final ReferenceCounter segmentReferenceCounter;
private final SegmentDescriptor descriptor;
public ReferenceCountingSegmentQueryRunner(
QueryRunnerFactory<T, Query<T>> factory,
- ReferenceCountingSegment adapter,
+ Segment segment,
+ ReferenceCounter segmentReferenceCounter,
Review comment:
note to self: Do these 2 need to be tightly coupled? DIg in a little more
here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
