suneet-s commented on a change in pull request #9247: Add JoinableFactory
interface and use it in the query stack.
URL: https://github.com/apache/druid/pull/9247#discussion_r370708638
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java
##########
@@ -206,6 +206,7 @@ public Appenderator newAppenderator(FireDepartmentMetrics
metrics, TaskToolbox t
toolbox.getSegmentAnnouncer(),
toolbox.getEmitter(),
toolbox.getQueryExecutorService(),
+ toolbox.getJoinableFactory(),
Review comment:
Just noticed this pattern in a few files. It would be nice if this was
abstracted away from the IndexTask and there was some factory that knew which
fields to use from the toolbox to build the Appenderator.
Obviously this doesn't need to be part of your change. Do you usually
create issues in github to track refactoring like this that would be nice to
have?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
