gianm commented on a change in pull request #9279: Guicify druid sql module
URL: https://github.com/apache/druid/pull/9279#discussion_r372166678
##########
File path: sql/src/main/java/org/apache/druid/sql/guice/SqlBindings.java
##########
@@ -41,4 +45,12 @@ public static void addOperatorConversion(
{
Multibinder.newSetBinder(binder,
SqlOperatorConversion.class).addBinding().to(clazz);
}
+
+ /**
+ * Returns a multiBinder that can modules can use to bind {@link
DruidCalciteSchema} to be used by the SqlModule
+ */
+ public static Multibinder<DruidCalciteSchema> calciteSchemaBinder(final
Binder binder)
Review comment:
Maybe do `addSchema` to be consistent with the others.
I recognize this isn't consistent with how DruidBindings works, but you
can't win 'em all. (Well, I guess you could win them all, if you changed
DruidBindings too.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
