gianm commented on a change in pull request #9279: Guicify druid sql module
URL: https://github.com/apache/druid/pull/9279#discussion_r372531831
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/query/SqlVsNativeBenchmark.java
##########
@@ -116,12 +115,10 @@ public void setup()
final PlannerConfig plannerConfig = new PlannerConfig();
this.walker = closer.register(new
SpecificSegmentsQuerySegmentWalker(conglomerate).add(dataSegment, index));
- final DruidSchema druidSchema =
CalciteTests.createMockSchema(conglomerate, walker, plannerConfig);
- final SystemSchema systemSchema =
CalciteTests.createMockSystemSchema(druidSchema, walker, plannerConfig);
-
+ final SchemaPlus rootSchema =
Review comment:
In that case, keeping to the style of the surrounding code is probably best.
I withdraw my request for consistency across files. (Unless we can reach
consensus on whether vars should be marked final whenever possible.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
