jihoonson commented on a change in pull request #9274: Refactoring some codes around ingestion URL: https://github.com/apache/druid/pull/9274#discussion_r373925106
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/OverlordCoordinatingSegmentAllocator.java ########## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common.task; + +import org.apache.druid.data.input.InputRow; +import org.apache.druid.indexer.partitions.PartitionsSpec; +import org.apache.druid.indexer.partitions.SecondaryPartitionType; +import org.apache.druid.indexing.appenderator.ActionBasedSegmentAllocator; +import org.apache.druid.indexing.common.TaskToolbox; +import org.apache.druid.indexing.common.actions.SegmentAllocateAction; +import org.apache.druid.indexing.common.actions.SurrogateAction; +import org.apache.druid.indexing.common.task.TaskLockHelper.OverwritingRootGenerationPartitions; +import org.apache.druid.indexing.common.task.batch.parallel.SupervisorTaskAccess; +import org.apache.druid.java.util.common.ISE; +import org.apache.druid.segment.indexing.DataSchema; +import org.apache.druid.segment.indexing.granularity.GranularitySpec; +import org.apache.druid.segment.realtime.appenderator.SegmentAllocator; +import org.apache.druid.segment.realtime.appenderator.SegmentIdWithShardSpec; +import org.apache.druid.timeline.partition.NumberedOverwritePartialShardSpec; +import org.apache.druid.timeline.partition.NumberedPartialShardSpec; +import org.apache.druid.timeline.partition.PartialShardSpec; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.io.IOException; + +/** + * Segment allocator which allocates new segments using the overlord per request. + */ +public class OverlordCoordinatingSegmentAllocator implements SegmentAllocator +{ + private final ActionBasedSegmentAllocator internalAllocator; + + OverlordCoordinatingSegmentAllocator( + final TaskToolbox toolbox, + final @Nullable SupervisorTaskAccess supervisorTaskAccess, + final DataSchema dataSchema, + final TaskLockHelper taskLockHelper, + final boolean appendToExisting, + final PartitionsSpec partitionsSpec + ) + { + this.internalAllocator = new ActionBasedSegmentAllocator( + toolbox.getTaskActionClient(), + dataSchema, + (schema, row, sequenceName, previousSegmentId, skipSegmentLineageCheck) -> { + final GranularitySpec granularitySpec = schema.getGranularitySpec(); + final Interval interval = granularitySpec + .bucketInterval(row.getTimestamp()) + .or(granularitySpec.getSegmentGranularity().bucket(row.getTimestamp())); + final PartialShardSpec partialShardSpec = createShardSpecFactory( + appendToExisting, + partitionsSpec, + taskLockHelper, + interval + ); + if (supervisorTaskAccess != null) { + return new SurrogateAction<>( + supervisorTaskAccess.getSupervisorTaskId(), + new SegmentAllocateAction( + schema.getDataSource(), + row.getTimestamp(), + schema.getGranularitySpec().getQueryGranularity(), + schema.getGranularitySpec().getSegmentGranularity(), + sequenceName, + previousSegmentId, + skipSegmentLineageCheck, + partialShardSpec, + taskLockHelper.getLockGranularityToUse() + ) + ); + } else { + return new SegmentAllocateAction( + schema.getDataSource(), + row.getTimestamp(), + schema.getGranularitySpec().getQueryGranularity(), + schema.getGranularitySpec().getSegmentGranularity(), + sequenceName, + previousSegmentId, + skipSegmentLineageCheck, + partialShardSpec, + taskLockHelper.getLockGranularityToUse() + ); + } + } + ); + } + + @Nullable + @Override + public SegmentIdWithShardSpec allocate( + InputRow row, + String sequenceName, + String previousSegmentId, + boolean skipSegmentLineageCheck + ) throws IOException + { + return internalAllocator.allocate(row, sequenceName, previousSegmentId, skipSegmentLineageCheck); + } + + private static PartialShardSpec createShardSpecFactory( Review comment: Renamed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
