jihoonson commented on a change in pull request #9274: Refactoring some codes around ingestion URL: https://github.com/apache/druid/pull/9274#discussion_r373925128
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialRangeSegmentGenerateTask.java ########## @@ -149,15 +150,19 @@ public boolean isReady(TaskActionClient taskActionClient) } @Override - IndexTaskSegmentAllocator createSegmentAllocator(TaskToolbox toolbox) throws IOException + CachingSegmentAllocator createSegmentAllocator(TaskToolbox toolbox, ParallelIndexSupervisorTaskClient taskClient) Review comment: Is it covered by `RangePartitionMultiPhaseParallelIndexingTest`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
