suneet-s commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r374242236
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseSubTask.java
##########
@@ -410,7 +313,14 @@ private SegmentAllocator createSegmentAllocator()
final DynamicPartitionsSpec partitionsSpec = (DynamicPartitionsSpec)
tuningConfig.getGivenOrDefaultPartitionsSpec();
final long pushTimeout = tuningConfig.getPushTimeout();
final boolean explicitIntervals =
granularitySpec.bucketIntervals().isPresent();
- final SegmentAllocator segmentAllocator = createSegmentAllocator(toolbox,
taskClient);
+ final SegmentAllocator segmentAllocator =
SegmentAllocators.forLinearPartitioning(
Review comment:
This should look at `partitionsSpec.getType()` otherwise if that
implementation changes to return a non linear type this will break
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
