jihoonson commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r374439393
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentGenerateTask.java
##########
@@ -164,7 +171,11 @@ abstract T createGeneratedPartitionsReport(
final PartitionsSpec partitionsSpec =
tuningConfig.getGivenOrDefaultPartitionsSpec();
final long pushTimeout = tuningConfig.getPushTimeout();
- final IndexTaskSegmentAllocator segmentAllocator =
createSegmentAllocator(toolbox);
+ final CachingSegmentAllocator segmentAllocator =
createSegmentAllocator(toolbox, taskClient);
+ final SequenceNameFunction sequenceNameFunction = new
NonLinearlyPartitionedSequenceNameFunction(
Review comment:
`PartialSegmentGenerateTask` is used when shuffling intermediate segment is
required. The hash or range partitionings need the shuffle, but for the linear
partitioning, I think it would never need it.
Hmm, well actually I think I can make `SequenceNameFunction` to be more
general so that it can create the proper sequence name from the
partialShardSpec. I will do it in the follow-up pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
