jihoonson commented on a change in pull request #9274: Refactoring some codes around ingestion URL: https://github.com/apache/druid/pull/9274#discussion_r374439187
########## File path: core/src/main/java/org/apache/druid/indexer/partitions/PartitionsSpec.java ########## @@ -41,6 +41,9 @@ String MAX_ROWS_PER_SEGMENT = "maxRowsPerSegment"; int HISTORICAL_NULL = -1; + @JsonIgnore + SecondaryPartitionType getType(); Review comment: This was originally to easily get some characteristics of the secondary partitioning type but turns out they are not that useful. But, I still find it useful especially when I need to do something based on the secondary partition type. I can use `switch` instead of multiple `if` statements. But maybe this will be unnecessary once I address https://github.com/apache/druid/pull/9274#discussion_r372148217 in the follow-up PR. I'll remove this method or add javadoc later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
