suneet-s commented on a change in pull request #9302: Not use for CoordinatorRuleManager.rules URL: https://github.com/apache/druid/pull/9302#discussion_r375404444
########## File path: server/src/main/java/org/apache/druid/server/router/CoordinatorRuleManager.java ########## @@ -58,7 +57,7 @@ private final ObjectMapper jsonMapper; private final Supplier<TieredBrokerConfig> config; - private final AtomicReference<ConcurrentHashMap<String, List<Rule>>> rules; + private final AtomicReference<Map<String, List<Rule>>> rules; Review comment: @jihoonson I'm not so familiar with this area of the code, so I'm happy to defer to your judgement. @zhenxiao can you describe what manual testing you've done to verify this change? I'm sorry if this is coming across as nagging, I've just experienced a lot of pain trying to triage concurrency issues in the past. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
