jihoonson commented on a change in pull request #9302: Not use for CoordinatorRuleManager.rules URL: https://github.com/apache/druid/pull/9302#discussion_r375496361
########## File path: server/src/main/java/org/apache/druid/server/router/CoordinatorRuleManager.java ########## @@ -58,7 +57,7 @@ private final ObjectMapper jsonMapper; private final Supplier<TieredBrokerConfig> config; - private final AtomicReference<ConcurrentHashMap<String, List<Rule>>> rules; + private final AtomicReference<Map<String, List<Rule>>> rules; Review comment: @suneet-s what kind of manual testings you think need to be done? The change in this PR looks pretty straightforward and I don't think this PR would lead to any sort of concurrency issues at least for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
