jihoonson commented on a change in pull request #9302: Not use for CoordinatorRuleManager.rules URL: https://github.com/apache/druid/pull/9302#discussion_r373887130
########## File path: server/src/main/java/org/apache/druid/server/router/CoordinatorRuleManager.java ########## @@ -58,7 +57,7 @@ private final ObjectMapper jsonMapper; private final Supplier<TieredBrokerConfig> config; - private final AtomicReference<ConcurrentHashMap<String, List<Rule>>> rules; + private final AtomicReference<Map<String, List<Rule>>> rules; Review comment: @suneet-s on the second thought, I think you're right. I thought this PR simply changes the type of the map in the `rules` which is not the case. If this PR makes the map in the `rules` immutable, those tests should be added in this PR. Thanks for clarifying it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
