clintropolis commented on a change in pull request #9501: Adding s3, gcs, azure integration tests URL: https://github.com/apache/druid/pull/9501#discussion_r392548762
########## File path: integration-tests/run_cluster.sh ########## @@ -47,12 +47,25 @@ # Make directories if they dont exist mkdir -p $SHARED_DIR/logs mkdir -p $SHARED_DIR/tasklogs + mkdir -p $SHARED_DIR/docker/extensions + mkdir -p $SHARED_DIR/docker/credentials # install druid jars rm -rf $SHARED_DIR/docker cp -R docker $SHARED_DIR/docker mvn -B dependency:copy-dependencies -DoutputDirectory=$SHARED_DIR/docker/lib + # move extensions into a seperate extension folder + # For druid-s3-extensions + mkdir -p $SHARED_DIR/docker/extensions/druid-s3-extensions Review comment: hmm, this doesn't seem a great way to handle this and doesn't really reflect how this will likely be run in practice, because the extension dependency jars will still all be on the classpath, just the extension jar itself will be in another folder. I think we will probably want to get the druid install similar to how it is in normal packaging to provide a more realistic test environment, which probably precludes using `mvn -B dependency:copy-dependencies`, or at least the way we are currently using it, so that way all extensions are split out in the separate extensions folder and not on the classpath. I guess this could be fine for now though, and we could figure out how to do this in a future PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
