maytasm3 commented on a change in pull request #9501: Adding s3, gcs, azure 
integration tests
URL: https://github.com/apache/druid/pull/9501#discussion_r393267066
 
 

 ##########
 File path: integration-tests/docker/druid.sh
 ##########
 @@ -73,4 +75,23 @@ setupConfig() {
       var=$(echo "$evar" | sed -e 's?^\([^=]*\)=.*?\1?g' -e 's?_?.?g')
       setKey $DRUID_SERVICE "$var" "$val"
   done
-}
\ No newline at end of file
+}
+
+setupData()
+{
+  # The "query" and "security" test groups require data to be setup before 
running the tests.
+  # In particular, they requires segments to be download from a pre-existing 
s3 bucket.
+  # This is done by using the loadSpec put into metadatastore and s3 
credientials set below.
+  if [ "$DRUID_INTEGRATION_TEST_GROUP" = "query" ] || [ 
"$DRUID_INTEGRATION_TEST_GROUP" = "security" ]; then
 
 Review comment:
   I think that's a good idea. Should definitely revisit this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to