maytasm3 commented on a change in pull request #9501: Adding s3, gcs, azure integration tests URL: https://github.com/apache/druid/pull/9501#discussion_r393264893
########## File path: integration-tests/run_cluster.sh ########## @@ -47,12 +47,25 @@ # Make directories if they dont exist mkdir -p $SHARED_DIR/logs mkdir -p $SHARED_DIR/tasklogs + mkdir -p $SHARED_DIR/docker/extensions + mkdir -p $SHARED_DIR/docker/credentials # install druid jars rm -rf $SHARED_DIR/docker cp -R docker $SHARED_DIR/docker mvn -B dependency:copy-dependencies -DoutputDirectory=$SHARED_DIR/docker/lib + # move extensions into a seperate extension folder + # For druid-s3-extensions + mkdir -p $SHARED_DIR/docker/extensions/druid-s3-extensions Review comment: I agree. It's very hard to separate out the extensions cleanly using `mvn -B dependency:copy-dependencies` Moving away from `mvn -B dependency:copy-dependencies` to how it is in normal packaging using the distribution is the right way in my opinion but is a much bigger/unrelated change than the purpose of this PR. For the purpose of this PR, as long as we don't load the extension jar which checks for configs/credentials to be set, we are good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
