suneet-s commented on a change in pull request #9559: error on value counter
overflow instead of writing sad segments
URL: https://github.com/apache/druid/pull/9559#discussion_r398815721
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/ColumnarDoublesSerializer.java
##########
@@ -29,5 +29,6 @@
public interface ColumnarDoublesSerializer extends Serializer
{
void open() throws IOException;
+ int size();
Review comment:
javadocs please. What does the size indicate? Number of rows in the column?
Or space it's taking up. Reading the code it looks like it's the former
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
