clintropolis commented on issue #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#issuecomment-604722125 >VSizeColumnarInts#get does this calculation Ah, i forgot to mention in the description that I didn't update `VSizeColumnarIntsSerializer` on purpose since it didn't follow the same pattern as the other implementations, and stores the size in bytes in the header in a checked cast from a long so would fail at indexing time already if it was too big. Also it shouldn't really be used in practice for real segments since it isn't compressed (except maybe for intermediary segments if `indexSpecForIntermediatePersists` is configured to be uncompressed, but these will be smallish segments). Since it reads directly from a `ByteBuffer` it is limited to the maximum size of a `ByteBuffer`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
