clintropolis commented on a change in pull request #9559: error on value
counter overflow instead of writing sad segments
URL: https://github.com/apache/druid/pull/9559#discussion_r398844534
##########
File path:
processing/src/main/java/org/apache/druid/segment/data/ColumnarDoublesSerializer.java
##########
@@ -29,5 +29,6 @@
public interface ColumnarDoublesSerializer extends Serializer
{
void open() throws IOException;
+ int size();
Review comment:
aw, I was just making it symmetrical with
[ColumnarFloatsSerializer](https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/segment/data/ColumnarFloatsSerializer.java)
and
[ColumnarLongsSerializer](https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/segment/data/ColumnarLongsSerializer.java),
neither of which have any docs either.
This area of the code in general is sort of barren of javadocs, so how about
a bargain: unless there is something else to change on this PR, how about I
just do a follow-up that adds javadocs to a bunch of this stuff?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
